[duplicate-code] Duplicate Code Analysis Report

[github-actions]

Analysis of commit e01fad9 — [log] Add debug logging to HTTP transport functions

Summary

The latest commit added debug logging to internal/mcp/http_transport.go, but several of the new log statements duplicate log messages that already existed in internal/mcp/connection.go. This results in double-logging when DEBUG=mcp:* is enabled: each transport attempt and each HTTP request/response round-trip is now logged twice (once via logConn in connection.go, once via logHTTP in http_transport.go), creating confusing and redundant debug output.

Two distinct patterns were found:

1. Duplicate "Attempting transport" log messages — Severity: Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: Double-logged "Attempting transport" messages #4584
2. Duplicate HTTP request/response log messages — Severity: Medium — See sub-issue [duplicate-code] Duplicate Code Pattern: Double-logged HTTP request/response round-trip messages #4585

Overall Impact

• Total Duplicated Lines: ~10 log lines (5 pairs)
• Affected Files: internal/mcp/connection.go, internal/mcp/http_transport.go
• Maintainability Risk: Medium — duplicate log noise makes transport debugging harder, not easier
• Refactoring Priority: Low–Medium — no correctness issue, but should be cleaned up

Next Steps

1. Review individual pattern sub-issues for detail
2. Remove the pre-existing logConn "Attempting" messages from connection.go (callers), since the logHTTP versions in the try-functions themselves are more informative (include serverID and connectTimeout)
3. Remove the redundant logConn HTTP response log in sendHTTPRequest since executeHTTPRequest already logs it

Analysis Metadata

• Analyzed Files: 2 Go files (internal/mcp/connection.go, internal/mcp/http_transport.go)
• Detection Method: Manual pattern search across changed files
• Commit: e01fad9d495aaa70f79616f2ea21ce531db4e368
• Analysis Date: 2026-04-26