Address review comments

Author: kishorhange111

Doc/deprecations/pending-removal-in-3.19.rst

@@ -22,3 +22,13 @@ Pending removal in Python 3.19
     supported depending on the backend implementation of hash functions.
     Prefer passing the initial data as a positional argument for maximum
     backwards compatibility.
+
+* :mod:`http.cookies`:
+
+  * :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
+    removed in Python 3.19.
+
+    This method generates a JavaScript snippet to set cookies in the browser,
+    which is no longer considered a standard or recommended approach.
+    Use :meth:`~http.cookies.BaseCookie.output` instead to generate HTTP
+    headers.

Doc/library/http.cookies.rst

@@ -110,7 +110,7 @@ Cookie Objects
    The meaning for *attrs* is the same as in :meth:`output`.
 
    .. deprecated:: 3.15
-      :meth:`!js_output` is deprecated and will be removed in Python 3.17.
+      :meth:`!js_output` is deprecated and will be removed in Python 3.19.
       Use :meth:`output` instead.
 
 

Doc/whatsnew/3.15.rst

@@ -1741,8 +1741,10 @@ New deprecations
     (Contributed by Bénédikt Tran in :gh:`134978`.)
 
 
+* :mod:`http.cookies`
+
 * :meth:`http.cookies.BaseCookie.js_output` is deprecated and will be
-  removed in Python 3.17. Use
+  removed in Python 3.19. Use
   :meth:`~http.cookies.BaseCookie.output` instead.
   (Contributed by kishorhange111 in :gh:`148849`.)
 

Lib/http/cookies.py

@@ -540,11 +540,12 @@ def __repr__(self):
             l.append('%s=%s' % (key, repr(value.value)))
         return '<%s: %s>' % (self.__class__.__name__, _spacejoin(l))
 
-    @warnings.deprecated(
-        "http.cookies.BaseCookie.js_output() is deprecated and will "
-        "be removed in Python 3.17; use output() instead"
-    )
     def js_output(self, attrs=None):
+        warnings._deprecated(
+            "http.cookies.BaseCookie.js_output",
+            "3.19",
+            "Use output() instead"
+        )
         """Return a string suitable for JavaScript."""
         result = []
         items = sorted(self.items())

Lib/test/test_http_cookies.py

@@ -176,7 +176,7 @@ def test_load(self):
         self.assertEqual(C.output(['path']),
             'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme; Version=1').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -185,7 +185,7 @@ def test_load(self):
         </script>
         """)
         cookie_encoded = base64.b64encode(b'Customer="WILE_E_COYOTE"; Path=/acme').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -295,7 +295,7 @@ def test_quoted_meta(self):
         self.assertEqual(C.output(['path']),
                          'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme')
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme; Version=1').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -304,7 +304,7 @@ def test_quoted_meta(self):
         </script>
         """)
         expected_encoded_cookie = base64.b64encode(b'Customer=\"WILE_E_COYOTE\"; Path=/acme').decode('ascii')
-        with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+        with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
             self.assertEqual(C.js_output(['path']), fr"""
         <script type="text/javascript">
         <!-- begin hiding
@@ -676,7 +676,7 @@ def test_control_characters_output(self):
             morsel._key = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                 with self.assertRaises(cookies.CookieError):
                     cookie.js_output()
 
@@ -685,7 +685,7 @@ def test_control_characters_output(self):
             morsel._coded_value = c0  # Override private variable.
             cookie = cookies.SimpleCookie()
             cookie["cookie"] = morsel
-            with self.assertWarnsRegex(DeprecationWarning, "BaseCookie.js_output"):
+            with self.assertWarnsRegex(DeprecationWarning, r"BaseCookie\.js_output"):
                 with self.assertRaises(cookies.CookieError):
                     cookie.js_output()