chore: update chokidar to v4 (#5657)

* chore: update chokidar to v4

* chore: only prevent interval be undefined

* feat: support for glob support

* feat: enhance watchFiles option to support ignored patterns with glob strings

* feat: add tests for watchFiles option with ignored glob array support

* fix: windows support

Author: bjohansebas

lib/Server.js

@@ -17,7 +17,7 @@ const schema = require("./options.json");
 /** @typedef {import("webpack").Stats} Stats */
 /** @typedef {import("webpack").MultiStats} MultiStats */
 /** @typedef {import("os").NetworkInterfaceInfo} NetworkInterfaceInfo */
-/** @typedef {import("chokidar").WatchOptions} WatchOptions */
+/** @typedef {import("chokidar").ChokidarOptions} WatchOptions */
 /** @typedef {import("chokidar").FSWatcher} FSWatcher */
 /** @typedef {import("connect-history-api-fallback").Options} ConnectHistoryApiFallbackOptions */
 /** @typedef {import("bonjour-service").Bonjour} Bonjour */
@@ -833,7 +833,7 @@ class Server {
 
       const usePolling = getPolling();
       const interval = getInterval();
-      const { poll, ...rest } = watchOptions;
+      const { poll: _poll, interval: _interval, ...rest } = watchOptions;
 
       return {
         ignoreInitial: true,
@@ -844,9 +844,7 @@ class Server {
         ignorePermissionErrors: true,
         // Respect options from compiler watchOptions
         usePolling,
-        interval,
-        ignored: watchOptions.ignored,
-        // TODO: we respect these options for all watch options and allow developers to pass them to chokidar, but chokidar doesn't have these options maybe we need revisit that in future
+        ...(interval !== undefined ? { interval } : {}),
         ...rest,
       };
     };
@@ -3188,10 +3186,42 @@ class Server {
    * @param {string | string[]} watchPath watch path
    * @param {WatchOptions=} watchOptions watch options
    */
-  watchFiles(watchPath, watchOptions) {
+  watchFiles(watchPath, watchOptions = {}) {
     const chokidar = require("chokidar");
+    const path = require("node:path");
+    const { globSync, isDynamicPattern } = require("tinyglobby");
+
+    const isWin = path.sep === "\\";
+    const toPosix = (/** @type {string} */ filePath) =>
+      isWin ? filePath.split(path.sep).join("/") : filePath;
+    const toNative = (/** @type {string} */ filePath) =>
+      isWin ? filePath.split("/").join(path.sep) : filePath;
+
+    const cwd = watchOptions.cwd ? toPosix(watchOptions.cwd) : undefined;
+
+    const expand = (/** @type {string} */ item) => {
+      const posix = toPosix(item);
+      return isDynamicPattern(posix)
+        ? globSync(posix, { cwd, absolute: true }).map(toNative)
+        : item;
+    };
+
+    const resolveGlobs = (/** @type {string | string[]} */ input) =>
+      (Array.isArray(input) ? input : [input]).flatMap((item) =>
+        typeof item === "string" ? expand(item) : item,
+      );
+
+    const resolvedPaths = resolveGlobs(watchPath);
+
+    if (typeof watchOptions.ignored === "string") {
+      watchOptions.ignored = resolveGlobs(watchOptions.ignored);
+    } else if (Array.isArray(watchOptions.ignored)) {
+      watchOptions.ignored = watchOptions.ignored.flatMap((item) =>
+        typeof item === "string" ? expand(item) : item,
+      );
+    }
 
-    const watcher = chokidar.watch(watchPath, watchOptions);
+    const watcher = chokidar.watch(resolvedPaths, watchOptions);
 
     // disabling refreshing on changing the content
     if (this.options.liveReload) {

package-lock.json

@@ -53,7 +53,7 @@
     "@types/ws": "^8.18.1",
     "ansi-html-community": "^0.0.8",
     "bonjour-service": "^1.3.0",
-    "chokidar": "^3.6.0",
+    "chokidar": "^4.0.3",
     "compression": "^1.8.1",
     "connect-history-api-fallback": "^2.0.0",
     "express": "^5.2.1",
@@ -66,6 +66,7 @@
     "schema-utils": "^4.3.3",
     "selfsigned": "^5.5.0",
     "serve-index": "^1.9.2",
+    "tinyglobby": "^0.2.15",
     "webpack-dev-middleware": "^8.0.2",
     "ws": "^8.20.0"
   },
@@ -85,6 +86,7 @@
     "@types/graceful-fs": "^4.1.9",
     "@types/node": "^24.0.14",
     "@types/node-forge": "^1.3.1",
+    "@types/picomatch": "^4.0.2",
     "@types/trusted-types": "^2.0.7",
     "acorn": "^8.14.0",
     "babel-jest": "^30.0.4",