Add PEP 517-compliant pip install workflow#4828
Open
gamesh411 wants to merge 3 commits intoEricsson:masterfrom
Open
Add PEP 517-compliant pip install workflow#4828gamesh411 wants to merge 3 commits intoEricsson:masterfrom
gamesh411 wants to merge 3 commits intoEricsson:masterfrom
Conversation
Rewrite setup.py to discover packages from source tree instead of requiring pre-built build_dist/ directory. Enables `pip install .` and `pip install -e .` as alternative to Makefile build. Remove the ldlogger C Extension that was in the original setup.py. It used setuptools Extension to build an .so file, but the runtime needs a logger binary as well (which the setuptools Extension did not produce). Build logging on linux still requires `make package` (which builds ldlogger correctly). Makefile build, Thrift API packages, and frontend build unchanged.
Makefile build does this via extend_version_file.py but rewritten setup.py missed it — rc builds would report 6.28.0 instead of 6.28.0-rc1.
gulyasgergely902
approved these changes
Apr 24, 2026
Collaborator
gulyasgergely902
left a comment
gulyasgergely902
left a comment
There was a problem hiding this comment.
LGTM apart from a few minor things.
| tu_collector --help | ||
|
|
||
| - name: Verify data files installed | ||
| run: | |
Collaborator
There was a problem hiding this comment.
I'd move this part to a separate file to make it more readable and invoke it here. Also given the simplicity of this task, couldn't it be done with bash instead of python?
|
|
||
| - name: Test analyze and parse | ||
| run: | | ||
| WORK="$RUNNER_TEMP/analyze-test" |
Collaborator
There was a problem hiding this comment.
Ideally I'd imagine this in a separate file too because of the length of the script. Also if JQ is available, counting reports could be done with it: CodeChecker parse "$WORK/reports" -e json | jq ".reports | length".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite setup.py to discover packages from source tree instead of requiring pre-built build_dist/ directory. Enables
pip install .andpip install -e .as alternative to Makefile build.Remove the ldlogger C Extension that was in the original setup.py. It used setuptools Extension to build an .so file, but the runtime needs a logger binary as well (which the setuptools Extension did not produce). Build logging on linux still requires
make package(which builds ldlogger correctly).Makefile build, Thrift API packages, and frontend build unchanged.