Light Freshness Edit: ASP.NET - host and deploy#37034
Light Freshness Edit: ASP.NET - host and deploy#37034lootle1 wants to merge 13 commits intodotnet:mainfrom
Conversation
|
Hi @lootle1, I will provide a review as soon as I see this is no longer in draft and intented for review or you ping me for one. Thanks for the contribution! |
|
Extending the name of the PR with a bit of detail since we had more than one by the same name. |
|
@dotnet-policy-service agree company="Microsoft" |
@dotnet-policy-service agree company="Microsoft" |
|
@lootle1, not sure how many files you intend to drop in this PR, but I think 5 is probibly good. We add too many articles with significant changes per PR and it becomes more problematic to revert, or address merge conflict issues in main or later pushed to live. If that messes too much with your process and cuts down on your work groove, I can go with more at a time if its worth the trade off. |
|
@wadepickett ah sounds good! I was continuing to add to have all the host-and-deploy articles in one PR. I'll stop with this last one I'm working on for this PR and stick with the five articles per moving forward, that's no problem! Overall finding these are in good shape so mostly link replacements and grammar/style updates. Hopefully fairly quick to review! |
|
@tdykstra @wadepickett this PR is ready for review. Top comment has an overview of the seven articles. I have one specific call out for a link but other than that should be fairly straightforward I believe. Let me know if any change requests, thank you! |
wadepickett
left a comment
There was a problem hiding this comment.
@lootle1, great work! I made some suggestions, which you can commit if you want to use them as-is. There were only two medium issues a couple very minor ones.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
|
@wadepickett thanks, all those changes looked good to me so committed. Unless @tdykstra has any change requests this PR should be all set. Appreciate you both! |
This PR contains freshness updates to the following articles:
Line 314, the link for NGINX: Using the Forwarded header redirects to a generic docs page. I replaced with this article link but wanted to confirm this is what you'd like to replace.
Minor grammar/style updates. Link path updates.
For request details, see 568764
Internal previews