Update hosted-services.md to reflect BackgroundService.StartAsync breaking change#37054
Open
dionrhys wants to merge 2 commits intodotnet:mainfrom
Open
Update hosted-services.md to reflect BackgroundService.StartAsync breaking change#37054dionrhys wants to merge 2 commits intodotnet:mainfrom
dionrhys wants to merge 2 commits intodotnet:mainfrom
Conversation
…aking change As of dotnet/runtime#116283 (in .NET 10), `BackgroundService.StartAsync` no longer blocks until the `BackgroundService.ExecuteAsync` implementation reaches an `await` point; `StartAsync` now always runs `ExecuteAsync` on the thread pool using `Task.Run`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of dotnet/runtime#116283 (issue: dotnet/runtime#36063) landing in .NET 10,
BackgroundService.StartAsyncno longer blocks until theBackgroundService.ExecuteAsyncimplementation reaches anawaitpoint;StartAsyncnow always runsExecuteAsyncon the thread pool usingTask.Run.This PR updates the wording for .NET 10+ versions to reflect the new behaviour. Previous versions of the page (.NET 8 and 9) retain the existing wording.
If it's desirable, I could also provide a warning of the breaking change on the .NET 10+ versions of the page in case someone's landed on latest docs but are actually working on .NET 8 or 9, so they don't get a surprise hang during app startup.
Let me know if you'd like any changes. ✌
Internal previews