[mob][photos] Share-sheet fallback when iOS Mail.app is unconfigured#10108
[mob][photos] Share-sheet fallback when iOS Mail.app is unconfigured#10108AmanRajSinghMourya wants to merge 6 commits intomainfrom
Conversation
Report Issue with logs now falls back to the system share sheet when FlutterEmailSender throws not_available (iOS Mail.app with no account). Also adds an internal/debug-only View logs entry on Help & Support.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48c29ad02e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return _shareAttachmentsViaSheet( | ||
| context, | ||
| subject: subject, | ||
| body: body, | ||
| attachmentPaths: attachmentPaths, |
There was a problem hiding this comment.
When FlutterEmailSender returns not_available, this branch calls _shareAttachmentsViaSheet without passing to, and the share payload only includes subject, text, and files. In the Report Issue / Send Logs flows this means the selected mail app opens without the support recipient prefilled, so users can easily send nowhere or to the wrong address while the app treats the action as success.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0f2e5bc6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ); | ||
| }, | ||
| ), | ||
| if (flagService.internalUser && kDebugMode) ...[ |
There was a problem hiding this comment.
Let's do internal user or kDebugMode
2 participants
To: support@ente.comsupport emailflagService.internalUser && kDebugMode.