Skip to content

[web][photos] upload to shared albums#10145

Draft
AswinAsok wants to merge 13 commits intoente-io:mainfrom
AswinAsok:feat/upload-to-shared-album
Draft

[web][photos] upload to shared albums#10145
AswinAsok wants to merge 13 commits intoente-io:mainfrom
AswinAsok:feat/upload-to-shared-album

Conversation

@AswinAsok
Copy link
Copy Markdown
Contributor

No description provided.

@AswinAsok AswinAsok marked this pull request as draft April 20, 2026 10:12
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 219de2d228

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

const visibleSearchFiles = suppressSharedFilesSavedByUser(
searchFiles,
state.user?.id,
state.view?.type == "albums" ? state.view.activeCollection : undefined,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass hidden album context to search duplicate suppression

In search mode, suppressSharedFilesSavedByUser only receives activeCollection when view.type == "albums"; for "hidden-albums" it always gets undefined. That makes hidden-album searches run the global suppression path and drop non-owned files that hash-match owned files, even when searching within a specific hidden album where files should remain visible. Include hidden-albums in this branch so album-scoped searches don’t lose results.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant