Skip to content

Add browser tokens for public link device limits#10171

Open
neeraj-pilot wants to merge 2 commits intoente-io:mainfrom
neeraj-pilot:deviceLimitImprovements
Open

Add browser tokens for public link device limits#10171
neeraj-pilot wants to merge 2 commits intoente-io:mainfrom
neeraj-pilot:deviceLimitImprovements

Conversation

@neeraj-pilot
Copy link
Copy Markdown
Contributor

Summary

  • add signed browser admission tokens for public collection and file-link device limits
  • apply collection admission to /public-collection/info and /public-collection/diff, and file-link admission to /file-link/info
  • persist and send tokens from albums, embed, and share clients using header-only transport with Museum CORS support

Validation

  • go test ./pkg/controller/public ./pkg/middleware ./pkg/api
  • git diff --check
  • Web typecheck not run: web/node_modules is missing, so workspace tsc commands fail with tsc not found

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14ba926426

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread server/pkg/middleware/file_link.go
Comment thread server/pkg/middleware/collection_link.go
@anandbaburajan
Copy link
Copy Markdown
Member

Tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants