fix: write UTF-8 bytes directly to stdout to avoid encoding errors#1800
Open
fuleinist wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: write UTF-8 bytes directly to stdout to avoid encoding errors#1800fuleinist wants to merge 1 commit intomicrosoft:mainfrom
fuleinist wants to merge 1 commit intomicrosoft:mainfrom
Conversation
On Windows (and other platforms) where sys.stdout.encoding is limited (e.g., cp1252, gbk), piping markitdown output to a file causes UnicodeEncodeError for characters outside the target encoding. The previous workaround of encode+decode with errors='replace' still failed when stdout.encoding was None, and didn't solve the root issue of stdout's limited encoding. This fix writes UTF-8 bytes directly to sys.stdout.buffer, which: - Bypasses stdout's text encoding limitation - Works reliably when stdout is piped or redirected - Handles all Unicode characters correctly - Falls back to print() with encoding='utf-8' for unusual cases Fixes: microsoft#1788 Fixes: microsoft#1597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: stdout Unicode encoding errors on Windows
On Windows (and other platforms) where
sys.stdout.encodingis limited (e.g., cp1252, gbk), piping markitdown output to a file causesUnicodeEncodeErrorfor characters outside the target encoding.Problem
The previous workaround of
encode+decodewitherrors='replace'still failed when stdout.encoding was None (piped stdout on some platforms), and didn't solve the root issue of stdout's limited text encoding.Solution
Write UTF-8 bytes directly to
sys.stdout.buffer, which:print()withencoding='utf-8'for unusual casesIssues Fixed
Testing