Fix text handling in PPTX converter#1819
Open
kelvinelove wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
fix: handle None text in PptxConverter to prevent TypeError Fixes microsoft#1808 When PowerPoint slides contain None text values (from malformed shapes or third-party-generated PPTX files), PptxConverter would crash with: "TypeError: can only concatenate str (not 'NoneType') to str" Updated three lines to safely handle None values using the `or ""` pattern: - Line 165: Title text concatenation - Line 167: Shape text concatenation - Line 197: Notes frame text concatenation This ensures that a single malformed shape no longer fails the entire file conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: handle None text in PptxConverter to prevent TypeError
Fixes #1808
When PowerPoint slides contain None text values (from malformed shapes or third-party-generated PPTX files), PptxConverter would crash with: "TypeError: can only concatenate str (not 'NoneType') to str"
Updated three lines to safely handle None values using the
or ""pattern:This ensures that a single malformed shape no longer fails the entire file conversion.