fix: OCR scanned pages when mixed with text pages#1821
Open
Brumbelow wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: OCR scanned pages when mixed with text pages#1821Brumbelow wants to merge 1 commit intomicrosoft:mainfrom
Brumbelow wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1791
When a multi-page PDF mixed selectable text with scanned pages, the converter only emitted content for pages that had either an image object or an extractable text layer. A scanned page with neither (no
page.images, nopage.extract_text()) silently fell through, and the whole-document_ocr_full_pagesfallback only runs when every page is empty. So pages 2..N just disappeared.This adds a small
_ocr_pagehelper that renders a single pdfplumber page to PNG and runs the configured OCR service on it, and calls it from the per-page loop when the page yields nothing the existing branches can use. The output format matches what_ocr_full_pagesalready emits, so existing snapshot tests are unaffected.Test: new
pdf_text_then_blank.pdffixture (~1.7 KB, page 1 has selectable text, page 2 is blank) plus a snapshot test that asserts both pages survive the round-trip.