Fix: guard against None text in PptxConverter#1826
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: guard against None text in PptxConverter#1826Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When python-pptx returns None for shape.text or notes_frame.text (e.g. third-party generators, SmartArt elements, malformed runs), the + operator threw TypeError and crashed the entire conversion. Fixed by adding 'or ""' guards on L165, L167, L197.
Author
|
Hi maintainers! This is a very small 3-line safety fix (guard against None text in PptxConverter). The PR has been waiting for a while with no reviews. Could someone take a look? Happy to make any adjustments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Fix: guard against None text in PptxConverter
Issue: #1808
When python-pptx returns None for
shape.textornotes_frame.text(e.g. third-party generators, SmartArt elements, malformed runs without text content), the string concatenation operator (+) threwTypeError: can only concatenate str (not NoneType) to strand crashed the entire PPTX conversion. One malformed shape would fail the whole file.Changes (3 lines, 1 file):
shape.text.lstrip()→(shape.text or "").lstrip()shape.text + "\n"→(shape.text or "") + "\n"notes_frame.text→(notes_frame.text or "")Testing:
or ""null-coalescing pattern already present in the same file (line 194)Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly,
RoomWithOutRoof