chore: consolidate --import flags into a single globals.js#58
Open
kraenhansen wants to merge 1 commit intomainfrom
Open
chore: consolidate --import flags into a single globals.js#58kraenhansen wants to merge 1 commit intomainfrom
kraenhansen wants to merge 1 commit intomainfrom
Conversation
Replace five separate --import flags in the test subprocess with a single globals.js that re-exports all global setup modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
legendecas
reviewed
Apr 27, 2026
| const ROOT_PATH = path.resolve(import.meta.dirname, "..", ".."); | ||
| const TESTS_ROOT_PATH = path.join(ROOT_PATH, "tests"); | ||
| const FEATURES_MODULE_PATH = path.join( | ||
| const GLOBALS_MODULE_PATH = path.join( |
Member
There was a problem hiding this comment.
Can we call this harness module? Though it installs global functions, I would prefer calling it with it's purpose, not it's solution.
Suggested change
| const GLOBALS_MODULE_PATH = path.join( | |
| const HARNESS_MODULE_PATH = path.join( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implementors/node/globals.jsthat imports all five global setup modules (features, assert, load-addon, gc, must-call). Using imports in the harness code is fine.--importflags inrunFileInSubprocesswith a single--importofglobals.jsTest plan
npm run node:testpasses (same results as before — only pre-existing failures from unbuilt addons)🤖 Generated with Claude Code