chore: remove unmaintained mastodon link from footer (#7873)#8843
chore: remove unmaintained mastodon link from footer (#7873)#88437487 wants to merge 2 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Updates the sidebar Reviewed by Cursor Bugbot for commit 9d673ae. Bugbot is set up for automated code reviews on this repo. Configure here. |
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
Removes an unmaintained social link from the site footer configuration, aligning the website’s footer icons with currently supported official channels.
Changes:
- Removed the Mastodon (
https://social.lfx.dev/@nodejs) entry fromsocialLinksin the site navigation config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When sidebar content overflows the viewport on desktop, users cannot scroll to see hidden items. Add flex-1 + overflow-y-auto + scroll-smooth to make the sidebar independently scrollable within the page layout. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9d673ae. Configure here.
| scroll-smooth | ||
| hidden; | ||
| } | ||
| } |
There was a problem hiding this comment.
Unrelated sidebar CSS change accidentally included
Medium Severity
The PR's changes to packages/ui-components/src/Containers/Sidebar/index.module.css add flex-1, overflow-y-auto, and scroll-smooth to .navigation. This makes each SidebarGroup an independently sized and scrollable region, nested within the main sidebar scroll, materially altering layout and scrolling behavior. These changes appear unrelated to the PR's stated purpose and also introduce an indentation inconsistency.
Reviewed by Cursor Bugbot for commit 9d673ae. Configure here.
|
Thanks for the PR. #8649 is already open and is blocked for the same reason that this one can't be merged |
|
@nodejs/nodejs-website @nodejs/web-infra Just a small cleanup removing the unmaintained Mastodon link. Thanks! |
|
@mikeesto Thanks for the review! I noticed this PR unintentionally includes unrelated sidebar CSS changes in addition to the Mastodon link removal, which may create unnecessary review noise. To keep things clean for maintainers, I’m closing this PR. I’ll resubmit a focused PR with only the intended change if needed. |
This closes #7873.
Summary
https://social.lfx.dev/@nodejsfrom footer social links innavigation.jsonVerification
🤖 Generated with Claude Code