Skip to content
20 changes: 19 additions & 1 deletion Doc/library/shlex.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ The :mod:`!shlex` module defines the following functions:
.. versionadded:: 3.8


.. function:: quote(s)
.. function:: quote(s, *, force=False)

Return a shell-escaped version of the string *s*. The returned value is a
string that can safely be used as one token in a shell command line, for
cases where you cannot use a list.

If *force* is :const:`True` then *s* will be quoted even if it is already
safe for a shell without being quoted.
Comment on lines +53 to +54
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If *force* is :const:`True` then *s* will be quoted even if it is already
safe for a shell without being quoted.
If *force* is :const:`True`, then *s* is unconditionally quoted,
even if it is already safe for a shell without being quoted.


.. _shlex-quote-warning:

.. warning::
Expand Down Expand Up @@ -91,8 +94,23 @@ The :mod:`!shlex` module defines the following functions:
>>> command
['ls', '-l', 'somefile; rm -rf ~']

The *force* keyword can be used to produce consistent behavior when
escaping multiple strings:

>>> from shlex import quote
>>> filenames = ['my first file', 'file2', 'file 3']
>>> filenames_some_escaped = [quote(f, force=False) for f in filenames]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> filenames_some_escaped = [quote(f, force=False) for f in filenames]
>>> filenames_some_escaped = [quote(f) for f in filenames]

>>> filenames_some_escaped
["'my first file'", 'file2', "'file 3'"]
>>> filenames_all_escaped = [quote(f, force=True) for f in filenames]
>>> filenames_all_escaped
["'my first file'", "'file2'", "'file 3'"]

.. versionadded:: 3.3

.. versionchanged:: next
The *force* keyword was added.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The *force* keyword was added.
Add the *force* parameter.


The :mod:`!shlex` module defines the following class:


Expand Down
9 changes: 9 additions & 0 deletions Doc/whatsnew/3.15.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,15 @@ New deprecations
Hugo van Kemenade in :gh:`148100`.)


* :mod:`shlex`:

* :func:`shlex.quote` has a new keyword-only parameter *force* that ensures
a string will always be quoted, even if it is already safe for a shell
without being quoted.
Comment on lines +1744 to +1746
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :func:`shlex.quote` has a new keyword-only parameter *force* that ensures
a string will always be quoted, even if it is already safe for a shell
without being quoted.
* Add *force* to :func:`shlex.quote` to force quoting a string,
even if it is already safe for a shell without being quoted.


(Contributed by Jay Berry in :gh:`148846`.)


* :mod:`struct`:

* Calling the ``Struct.__new__()`` without required argument now is
Expand Down
15 changes: 11 additions & 4 deletions Lib/shlex.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,12 @@ def join(split_command):
return ' '.join(quote(arg) for arg in split_command)


def quote(s):
"""Return a shell-escaped version of the string *s*."""
def quote(s, *, force=False):
"""Return a shell-escaped version of the string *s*.

If *force* is *True* then *s* will be quoted even if it is
already safe for a shell without being quoted.
Comment on lines +323 to +324
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the docstring with the updated doc I suggested as well.

"""
if not s:
return "''"

Expand All @@ -329,8 +333,11 @@ def quote(s):
safe_chars = (b'%+,-./0123456789:=@'
b'ABCDEFGHIJKLMNOPQRSTUVWXYZ_'
b'abcdefghijklmnopqrstuvwxyz')
# No quoting is needed if `s` is an ASCII string consisting only of `safe_chars`
if s.isascii() and not s.encode().translate(None, delete=safe_chars):
if (not force
and s.isascii() and not s.encode().translate(None, delete=safe_chars)
):
Comment thread
jb2170 marked this conversation as resolved.
Outdated
# No quoting is needed if we're not forcing quoting
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# No quoting is needed if we're not forcing quoting
# No quoting is needed if we are not forcing quoting

# and `s` is an ASCII string consisting only of `safe_chars`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# and `s` is an ASCII string consisting only of `safe_chars`
# and `s` is an ASCII string consisting only of `safe_chars`.

return s

# use single quotes, and put single quotes into double quotes
Expand Down
22 changes: 22 additions & 0 deletions Lib/test/test_shlex.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,28 @@ def testQuote(self):
"'test%s'\"'\"'name'\"'\"''" % u)
self.assertRaises(TypeError, shlex.quote, 42)
self.assertRaises(TypeError, shlex.quote, b"abc")
# self.assertRaises(TypeError, shlex.quote, None)
Comment thread
jb2170 marked this conversation as resolved.
Outdated

def testForceQuote(self):
# ensure default `force` behavior does not unnecessarily quote strings
self.assertEqual(shlex.quote("no-quotes-needed"),
"no-quotes-needed")

# ensure `force=False` does not unnecessarily quote strings
self.assertEqual(shlex.quote("no-quotes-needed", force=False),
"no-quotes-needed")

# ensure `force=True` does quote strings that
# would not be quoted if using `force=False`
self.assertEqual(shlex.quote("no-quotes-needed", force=True),
"'no-quotes-needed'")

# ensure `force` does not affect outcome for strings that
# need quoting anyways
self.assertEqual(shlex.quote("quotes needed", force=False),
"'quotes needed'")
self.assertEqual(shlex.quote("quotes needed", force=True),
"'quotes needed'")
Comment thread
jb2170 marked this conversation as resolved.
Outdated

def testJoin(self):
for split_command, command in [
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Add *force* keyword only argument to :func:`shlex.quote` to always quote the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the NEWS entry with the updated What's New as well.

string passed to it, even if it is already safe for a shell without being
quoted.
Loading