Skip to content

gh-148954: sanitize methodname in xmlrpc.client.dumps() to prevent XML injection #148968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanyamk23 wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −1
Open

gh-148954: sanitize methodname in xmlrpc.client.dumps() to prevent XML injection #148968

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e67dfd
gh-148954: sanitize methodname in xmlrpc.client.dumps() to prevent XM…
sanyamk23 Apr 24, 2026
6e1f96d
gh-148954: add tests for methodname sanitization in dumps()
sanyamk23 Apr 24, 2026
115b915
gh-148954: rename test and wrap long line
sanyamk23 Apr 24, 2026
4392570
gh-148954: remove test comments
sanyamk23 Apr 24, 2026
bbf4bdf
gh-148954: move NEWS entry to Library
sanyamk23 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/test/test_xmlrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,15 @@ def test_dump_encoding(self):
self.assertEqual(xmlrpclib.loads(strg)[0][0], value)
self.assertEqual(xmlrpclib.loads(strg)[1], methodname)

def test_methodname_sanitization(self):
Comment thread
sanyamk23 marked this conversation as resolved.
Outdated
# gh-148954: test that methodname is sanitized in dumps()
payload = 'foo</methodName><injected attr="evil"/><methodName>bar'
s = xmlrpclib.dumps((), methodname=payload)
self.assertIn('<methodName>foo&lt;/methodName&gt;&lt;injected attr="evil"/&gt;&lt;methodName&gt;bar</methodName>', s)
Comment thread
sanyamk23 marked this conversation as resolved.
Outdated
self.assertNotIn('<injected attr="evil"/>', s)
load, m = xmlrpclib.loads(s)
self.assertEqual(m, payload)

def test_dump_bytes(self):
sample = b"my dog has fleas"
self.assertEqual(sample, xmlrpclib.Binary(sample))
Expand Down
2 changes: 1 addition & 1 deletion Lib/xmlrpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,7 @@ def dumps(params, methodname=None, methodresponse=None, encoding=None,
data = (
xmlheader,
"<methodCall>\n"
"<methodName>", methodname, "</methodName>\n",
"<methodName>", escape(methodname), "</methodName>\n",
data,
"</methodCall>\n"
)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Security/2026-04-24-19-54-00.gh-issue-148954.v1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix XML injection vulnerability in :func:`xmlrpc.client.dumps` where the ``methodname``
Copy link
Copy Markdown
Member

@picnixz picnixz Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanFromIreland Was it expected to be fixed as a regular bugfix or security issue? in the former case, please move the NEWS entry to "Library" (the esasiest way to do it is simply to remove that file and re-create one from scratch).

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was expected to be treated as a regular bugfix, please do move it to "library," otherwise it is misleading and contradicts the security warning.

was not being escaped before interpolation into the XML body.
Loading