gh-149046: fix: correctly handle str subclasses in StringIO#149047
Draft
KowalskiThomas wants to merge 3 commits intopython:mainfrom
Draft
gh-149046: fix: correctly handle str subclasses in StringIO#149047KowalskiThomas wants to merge 3 commits intopython:mainfrom
StringIO#149047KowalskiThomas wants to merge 3 commits intopython:mainfrom
Conversation
9451278 to
47788ec
Compare
47788ec to
4f0649e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR is, in a way, a follow-up from #148241.
This other PR fixed a breaking change in behaviour where classes inheriting
strwould have__str__called on them when instead of using the "underlying"stritself. The PR fixed the problem for JSON serialisation, but seemingly missed some other call sites, includingStringIO. This seems to affect Python 3.14+ (but works as expected on 3.13).This is a reproducer.
... gives
AssertionError: got 'WRONG_VALUE'StringIObreaking change forstrsubclasses #149046