Un-skip previously-broken test_get_type_hints_modules_forwardref#149048
Open
KowalskiThomas wants to merge 1 commit intopython:mainfrom
Open
Un-skip previously-broken test_get_type_hints_modules_forwardref#149048KowalskiThomas wants to merge 1 commit intopython:mainfrom
test_get_type_hints_modules_forwardref#149048KowalskiThomas wants to merge 1 commit intopython:mainfrom
Conversation
KowalskiThomas
changed the title
test_get_type_hints_modules_forwardref
KowalskiThomas
requested review from
AlexWaygood and
JelleZijlstra
as code owners
Member
|
Nice! Is this also fixed on the 3.14 and 3.13 branches? |
Contributor
Author
|
I believe the fix for the test was introduced in your ac14d4a commit, which apparently did go into 3.14, so I would say it does "need" to get backported to 3.14 for completeness' sake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR removes the
skipdecorator on a test that used to be broken but that was "accidentally fixed" by a previous change.I don't think this warrants a news entry nor a dedicated issue so leaving it like that unless a reviewer thinks it should be otherwise.