Conversation
|
For this, we’ll first need to migrate to Node.js’s test runner so everything works properly and we avoid weird issues, since Jest only has experimental support for it (in a separate PR to make it easier to review). Then we can proceed with this one by migrating to ESM, so it stays focused on that change. After that, we continue with the http-proxy-middleware PR, which will allow us to update that dependency and complete the migration to ESM-only. |
| // ES2025 needed for import attributes (`import(x, { with: ... })`). | ||
| // eslint-config-webpack pins ecmaVersion to 2024 for Node 22. | ||
| ecmaVersion: "latest", | ||
| }, |
There was a problem hiding this comment.
This should work without this, because we automatically takes ecmaVersion from node in package.json
There was a problem hiding this comment.
see https://github.com/webpack/eslint-config-webpack/blob/32eaa6f7518e0fd64f305e055354320ad3d1ec2e/configs.js#L73 and the problem is that estree treats that functionality mentioned in the comment as part of ES2025, but for Node 22, we have it available
There was a problem hiding this comment.
hm, I think we need to fix it in our shared config, but let's do it separately, not here
|
Also feel free to use experimental support of ecma modules in jest, it should work, to avoid unnecessary work right now, we will migrate to nodejs test runner later, will be great to make a release soon |
2 participants
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI